Initialize playwright and add some very basic end to end tests#242
Initialize playwright and add some very basic end to end tests#242nilsnolde merged 2 commits intovalhalla:masterfrom
Conversation
mustaphaturhan
added
enhancement
|
Thanks, this has been on the todo list for a long time! |
nilsnolde
left a comment
nilsnolde
left a comment
There was a problem hiding this comment.
Thanks a lot @mustaphaturhan , this is so so valuable! I'm very happy with playwright, super easy to read:)
BTW, feel free to use the upstream remote. Currently the GHA isn't working because the domain gis-ops.com went out of service recently, but I'm currently in the process of re-instating it, so soon we'd have a preview on PRs again when using upstream remote.
| run: npx playwright install --with-deps | ||
| - name: Run Playwright tests | ||
| run: npx playwright test | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
what's the upload for? I guess it's an HTML coverage report? does it also print that to stdout in the previous step? or is there some other magic, e.g. like coveralls (adds a PR comment with a detailed coverage report, see nilsnolde/valhalla-qgis-plugin#31 (comment)) or codecov (adds check items in the PR and annotates the "Changed files" tab) to get a coverage report?
There was a problem hiding this comment.
playwright generates an html after every run and gives you a chance to preview what happened while running the test. however, I configure it to generate the images and videos only if something went wrong while running the test. this will be very useful when something passed on your local, but failed on CI. more info here.
for features like coveralls or codecov, I believe we can setup something like playwright-report-comment.
3 participants
Related #58
🛠️ Fixes Issue
👨💻 Changes proposed